Draft
Conversation
tiero
reviewed
Oct 27, 2021
Member
tiero
left a comment
There was a problem hiding this comment.
I would change the behavior and signature of allowCoin to something more high level such us approveSpend API, otherwise the web app must handle coin selection and utxos outpoint, which can be not that practical
tiero
reviewed
Oct 27, 2021
Collaborator
Author
|
UPDATE: enrich CoinosProvider (implementing the first version of the interface proposed here<--) |
This was referenced Dec 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to let the user pair Marina with a cosigner and then "allow" to spend some funds via another injected provider.
New Domain:
Accountwalletreducer now stores the account data. Each account is identified by anAccountID.encrypted mnemonicand all the main data used to restore the Main Marina wallet represents themainAccount.Restricted Asset account
Cosignerinterface."Allowance" provider
the
coinosprovider is injected viainject-script.ts. Its implementation is described in coinosBroker file. It let's togetCoins--> returns the utxos owned by the 2of2 Marina account andallowCoin--> create a SIGHASH_NONE tx and send it toCosigner(via Cosigner.allow method).mocked cosigner
This PR uses a mocked cosigner for testing purposes as a
Cosignerinterface.TODO:
This PR is the first base block for the restricted assets but need some task to be fully complete:
@tiero please review